Change TS compiler to ts-proto and nice-grpc for backwards compatibility #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Validate Pull Request / check_buf (pull_request).
|
|
2.0.1 is fine in this case 👍 nothing uses 2.0.0 like you said, so I don't think it matters that much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stems from attempting to upgrade the account server to the new package and realising that using protobuf-ts requires a whole different server runtime, which I didn't consider when making this repo.
Changes:
Question for @jonbarrow: This would technically be a major change given it's a breaking change from 2.0.0, but since we have not used this package yet, would we be happy just making it a patch version? (2.0.1 in this case)
Still needs to be done: